Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Fixed legacy wallet imports #23609

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

muliswilliam
Copy link
Collaborator

@muliswilliam muliswilliam commented May 13, 2024

Resolves brave/brave-browser#38074

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Screen.Recording.2024-05-13.at.19.52.45.mov

@muliswilliam muliswilliam requested review from a team as code owners May 13, 2024 16:59
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels May 13, 2024
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@muliswilliam muliswilliam merged commit 728b6e3 into master May 14, 2024
18 checks passed
@muliswilliam muliswilliam deleted the fix-legacy-wallet-import branch May 14, 2024 13:34
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 14, 2024
muliswilliam added a commit that referenced this pull request May 16, 2024
* Fixed legacy wallet imports

* Set type for alert and add padding
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.68.39 Chromium: 125.0.6422.76 (Official Build) nightly (64-bit)
Revision 8d3c424
OS Linux
  • Verified steps from issue description
  • Verified Legacy wallet import option is shown during onboarding
  • Verified able to import legacy wallet into new wallet without any issue
23609.mp4

kjozwiak pushed a commit that referenced this pull request May 23, 2024
fix(wallet): Fixed legacy wallet imports (#23609)

* Fixed legacy wallet imports

* Set type for alert and add padding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
6 participants