Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Add tab usage metrics #23607

Merged
merged 1 commit into from
May 21, 2024
Merged

[iOS] Add tab usage metrics #23607

merged 1 commit into from
May 21, 2024

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented May 13, 2024

Resolves brave/brave-browser#36592

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See #20159 test plan

@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels May 13, 2024
@kylehickinson kylehickinson self-assigned this May 13, 2024
@kylehickinson kylehickinson requested a review from a team as a code owner May 13, 2024 16:42
var urlSubmissionTotalStorage = P3ATimedStorage<Int>.urlSubmissionTotalStorage
var urlSubmissionNewTabStorage = P3ATimedStorage<Int>.urlSubmissionNewTabStorage

if let tab, !tab.isPrivate {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need this private mode check

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3A cannot report on private mode usage, so it's best that we keep it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I should also guard recordCreateTabAction as well in private mode

@kylehickinson kylehickinson merged commit 6897163 into master May 21, 2024
19 checks passed
@kylehickinson kylehickinson deleted the ios-tab-usage-metric branch May 21, 2024 22:00
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
3 participants