Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Wallet) Refactor Network selector adapter #23600

Merged
merged 16 commits into from
May 14, 2024
Merged

Conversation

simoarpe
Copy link
Collaborator

@simoarpe simoarpe commented May 13, 2024

Resolves brave/brave-browser#37812

Resolves brave/brave-browser#37811

Resolves brave/brave-browser#36253

Preview

Details

Refactor network selector adapter and introduce the following improvements:

  • Show only networks that support Dapps
  • Select ETH by default once a Wallet is created for the first time
  • Remove new account action icon and change title to better reflect UI purpose
  • Load network logos from vector assets

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Default network selection

  • Create a new Wallet and make sure to include all the available networks
  • Finish Wallet creation
  • Navigate to Wallet panel and observe the selected network is ETH account

Network selector alignment

  • Create a new Wallet and make sure to include all the available networks
  • Finish Wallet creation
  • Navigate to Wallet panel and tap on network selector button
  • Observe network items are properly aligned

New account item removal

  • Create a new Wallet and make sure to include all the available networks
  • Finish Wallet creation
  • Navigate to Wallet panel and tap on account selection
  • Observe the new title "Change Selected Account"
  • Observe the plus icon is not shown

@simoarpe simoarpe added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS feature/web3/wallet CI/skip-windows-x64 Do not run CI builds for Windows x64 labels May 13, 2024
@simoarpe simoarpe self-assigned this May 13, 2024
@simoarpe simoarpe requested review from deeppandya and a team as code owners May 13, 2024 15:00
@@ -0,0 +1,19 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright (c) 2022 The Brave Authors. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit : year should be 2024

You can obtain one at https://mozilla.org/MPL/2.0/.
-->

<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the outside container here ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all! I'm removing it.

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@simoarpe simoarpe force-pushed the simone/network-selector-dapps branch from 9a658a6 to a246977 Compare May 14, 2024 12:26
@simoarpe simoarpe merged commit d51670a into master May 14, 2024
18 checks passed
@simoarpe simoarpe deleted the simone/network-selector-dapps branch May 14, 2024 14:23
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 feature/web3/wallet
Projects
None yet
3 participants