-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ads] Fixes sometimes Play and Pause button are not responsive on NTT fullscreen video ad #23372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fullscreen video ad
kylehickinson
approved these changes
May 1, 2024
...ios/Sources/Brave/Frontend/Browser/New Tab Page/Backgrounds/NewTabPageVideoButtonsView.swift
Outdated
Show resolved
Hide resolved
tmancey
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (but please sanity test and add test cases for QA for all code paths that touch maybeCancelPlay
and startAutoplay
)
Verification PASSED on Test Case 1
RPReplay_Final1715117027.MP4Test Case 2
Test Case 3
RPReplay_Final1715117964.movTest Case 4
RPReplay_Final1715118327.movTest Case 5
RPReplay_Final1715118608.MP4Test Case 6
RPReplay_Final1715118706.MP4Test Case 7
RPReplay_Final1715119153.movTest Case 8
RPReplay_Final1715119323.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#37893
Resolves brave/brave-browser#37889
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Test case 1
Test case 2
Test case 3
EXPECTATION: Designated stop keyframe is shown
Test case 4
EXPECTATION: Designated stop keyframe is shown
Test case 5
EXPECTATION: Designated stop keyframe is shown
Test case 6
EXPECTATION: Designated stop keyframe is shown
Test case 7
EXPECTATION: Designated stop keyframe is shown
Test case 8
EXPECTATION: Designated stop keyframe is shown