Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set radius for secondary web view and focus border #23312

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

sangwoo108
Copy link
Contributor

Resolves brave/brave-browser#37924

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@simonhong
Copy link
Member

It seems web view's radius is not set properly in split view like below.
image

@sangwoo108
Copy link
Contributor Author

Hum, that seems to be left side of the focused web view(main contents webview). I'll take a look.

Comment on lines +1095 to +1097
// TODO(sko) We need to override
// BrowserView::GetDevToolsDockedPlacement(). It depends on coordinate of
// it but in split view mode, the calculation is not correct.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonhong , that was related to this TODO() part. Disabled devtools placement code temporarily.

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ 👍🏼

@sangwoo108 sangwoo108 merged commit b7bdbd2 into master Apr 30, 2024
19 checks passed
@sangwoo108 sangwoo108 deleted the sko/split-view-radius branch April 30, 2024 00:40
@github-actions github-actions bot added this to the 1.67.x - Nightly milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants