Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News]: Add timeouts to fetches #23190

Merged
merged 2 commits into from
Apr 25, 2024
Merged

[Brave News]: Add timeouts to fetches #23190

merged 2 commits into from
Apr 25, 2024

Conversation

fallaciousreasoning
Copy link
Contributor

Hopefully this will fix the infinite loading issue in feeds (which I think is related to long response times from servers).

Maybe Resolves brave/brave-browser#31228

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See issue

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@fallaciousreasoning fallaciousreasoning enabled auto-merge (squash) April 25, 2024 04:57
@fallaciousreasoning fallaciousreasoning merged commit 56b8c86 into master Apr 25, 2024
19 checks passed
@fallaciousreasoning fallaciousreasoning deleted the bn-no-feed branch April 25, 2024 06:20
@github-actions github-actions bot added this to the 1.67.x - Nightly milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants