Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sites using Opensearch don't always appear in Brave "recently visited" search engines #38129

Open
Brave-Matt opened this issue May 7, 2024 · 4 comments · May be fixed by brave/brave-core#23659
Open

Sites using Opensearch don't always appear in Brave "recently visited" search engines #38129

Brave-Matt opened this issue May 7, 2024 · 4 comments · May be fixed by brave/brave-core#23659
Assignees
@deeppandya
Labels
feature/global-settings Settings at browser level independent of shields settings feature/search OS/Android Fixes related to Android browser functionality

Comments

@Brave-Matt
Copy link

Description

Some search engines will not appear in Brave's Recently visited sites (Settings --> Search Engines --> Standard tab) and therefore cannot be set as the default search engine for the browser. The behavior seems to be inconsistent with Chrome's behavior, the expected behavior, and no discernible pattern is there.

When testing in Brave, I got the following results for different search engines — these sites do not appear Brave but do appear in Chrome:

  • Yahoo! search
  • Amazon.com
  • dogpile.com
  • mojeek.com
  • you.com
  • carter-cash.com
  • scholar.google.com

Since they use the same protocol, search engines that appear in Chrome should also appear in Brave. Further, any site that supports opensearch should appear in Recently visited in Brave.

Issue reproduces how often

Every time

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? No
  • Can you reproduce this issue with the current Play Store Nightly version? No

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: Android 14

Brave version

1.65.126

Additional information

A user reporting the same issue:
https://community.brave.com/t/add-presearch-as-my-default-search-engine-on-brave-mobile-on-android/541072/10
@Brave-Matt Brave-Matt added feature/global-settings Settings at browser level independent of shields settings feature/search OS/Android Fixes related to Android browser functionality labels May 7, 2024
@bsclifton
Copy link
Member

bsclifton commented May 7, 2024 •
edited

@Brave-Matt this should be happening on purpose. Maybe we didn't do a proper UI on Android, but there's a preference (disabled by default) that can be enabled to index OpenSearch compatible engines (Index other search engines). You can find it (on Desktop) on brave://settings/search
image

We may need to make this visible on Android if it's not there already
cc: @deeppandya

@deeppandya
Copy link

@Brave-Matt this should be happening on purpose. Maybe we didn't do a proper UI on Android, but there's a preference (disabled by default) that can be enabled to index OpenSearch compatible engines (Index other search engines). You can find it (on Desktop) on brave://settings/search
image

We may need to make this visible on Android if it's not there already
cc: @deeppandya

That's interesting. We can have a similar option in the search engine page for android. I am going to add the issue for triage.

This was referenced May 7, 2024
Closed
Open
@deeppandya deeppandya self-assigned this May 8, 2024
@deeppandya deeppandya linked a pull request May 15, 2024 that will close this issue
Open
24 tasks
@deeppandya
Copy link

@bsclifton upon checking the details, it seems Index other search engines option is enabled by default for android based on https://github.com/brave/brave-core/blob/78c4a3fa0bf401aec67aee299a8f522286947866/browser/brave_profile_prefs.cc#L399

@deeppandya
Copy link

@Brave-Matt i have verified the issue, it should be resolved with 1.65.133. i have also checked latest beta and nightly, both works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/global-settings Settings at browser level independent of shields settings feature/search OS/Android Fixes related to Android browser functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Option for Index other search engine brave/brave-core
3 participants
@Brave-Matt @bsclifton @deeppandya