Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] Same document navigations should trigger NotifyTabDidChange #38272

Open
aseren opened this issue May 13, 2024 · 1 comment
Open

[ads] Same document navigations should trigger NotifyTabDidChange #38272

aseren opened this issue May 13, 2024 · 1 comment
Assignees
@aseren
Labels
blocked bug feature/ads OS/iOS Fixes related to iOS browser functionality
Projects
Ads

Comments

@aseren
Copy link

aseren commented May 13, 2024 •
edited

Steps to Reproduce

  1. Open Single Page Application webpage
  2. Tap a same document navigation link (navigates inside Single Page Application)

Actual result:

Same document navigation doesn't trigger NotifyTabDidChange

Expected result:

Same document navigation triggers NotifyTabDidChange

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced
@aseren aseren added bug feature/ads OS/iOS Fixes related to iOS browser functionality labels May 13, 2024
@aseren aseren added this to Dev Concern in Ads May 13, 2024
@aseren aseren moved this from Dev Concern to New issues in Ads May 13, 2024
@aseren aseren changed the title [ads] Same document navigations should trigger NotifyTabDidChange [ads] Same document navigations should trigger NotifyTabDidChange May 13, 2024
This was referenced May 13, 2024
Open
Closed
@aseren aseren self-assigned this May 14, 2024
@aseren aseren moved this from New issues to In progress in Ads May 14, 2024
@aseren
Copy link
Author

aseren commented May 29, 2024

The original issue is caused by same document navigation detection implementation on iOS and should be fixed after proper same document navigation implementation.
So the issue is blocked until #38662 is resolved.

@aseren aseren moved this from In progress to Blocked in Ads May 29, 2024
@aseren aseren added the blocked label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
blocked bug feature/ads OS/iOS Fixes related to iOS browser functionality
Projects
Ads
  
Blocked
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ads] Fixes same document navigations should trigger NotifyTabDidChange brave/brave-core
1 participant
@aseren