Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button text cut off on dialog when in split view [Phone] #38269

Closed
Uni-verse opened this issue May 13, 2024 · 2 comments · Fixed by brave/brave-core#23617
Closed

Button text cut off on dialog when in split view [Phone] #38269

Uni-verse opened this issue May 13, 2024 · 2 comments · Fixed by brave/brave-core#23617
Labels
android-phone-specific bug OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude
Milestone
1.66.x - Release

Comments

@Uni-verse
Copy link
Contributor

Uni-verse commented May 13, 2024 •
edited

Description

Button text is cut off when Multiple windows detected dialog is shown in split view.

Related to: #38203

Steps to reproduce

  1. New install
  2. Set Enable multiple windows to ON in Appearance settings
  3. Go back to new tab, long press on favorites and select Open in new window
  4. While in split view, open menu in either one of the windows and turn Enable multiple windows toggle to OFF in Appearance settings
  5. Observe dialog

Actual result

Button text is cut off. Should probably be stacked or dialog should be expanded.
Screenshot 2024-05-13 at 11 00 24 AM

Expected result

Screenshot 2024-05-13 at 11 00 43 AM

Issue reproduces how often

Always

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung GS21
  • Android version: 13

Brave version

1.66.105
@tapanmodh tapanmodh mentioned this issue May 13, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 15, 2024
This was referenced May 15, 2024
Merged
Merged
@Uni-verse Uni-verse mentioned this issue May 15, 2024
Open
@kjozwiak
Copy link
Member

The above requires 1.66.10 or higher for 1.66.x verification 👍

@Uni-verse
Copy link
Contributor Author

Verified on Samsung Galaxy S21 using version:

Brave	1.66.110 Chromium: 125.0.6422.60 (Official Build) (64-bit) 
Revision	de593d76e2ca4d02faa85bf1ca27bcf3ee46793c
OS	Android 13; Build/TP1A.220624.014; 33; REL

New Users

  1. New install
  2. Set Enable multiple windows to ON in Appearance settings
  3. Go back to new tab, long press on favorites and select Open in new window
  4. While in split view, open menu in either one of the windows and turn Enable multiple windows toggle to OFF in Appearance settings
  5. Observe dialog

Existing Users

  1. Install 1.65.133
  2. Upgrade to 1.66.110
  3. Set Enable multiple windows to ON in Appearance settings
  4. Go back to new tab, long press on favorites and select Open in new window
  5. While in split view, open menu in either one of the windows and turn Enable multiple windows toggle to OFF in Appearance settings
  6. Observe dialog
  • Ensured button text dialog visibility is improved from the previous version.
  • Ensured Merge windows and Close windows buttons are working.
Example Example
Screenshot 2024-05-16 at 10 29 25 AM Screenshot 2024-05-16 at 10 32 23 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android-phone-specific bug OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.66.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] fix multiple window dialog text cutoff brave/brave-core
3 participants
@kjozwiak @Uni-verse @brave-builds