Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to import Crypto Wallets during new onboarding #38074

Closed
srirambv opened this issue May 6, 2024 · 2 comments · Fixed by brave/brave-core#23609
Closed

Unable to import Crypto Wallets during new onboarding #38074

srirambv opened this issue May 6, 2024 · 2 comments · Fixed by brave/brave-core#23609
Assignees
@muliswilliam
Labels
bug feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Milestone
1.67.x - Beta

Comments

@srirambv
Copy link
Contributor

srirambv commented May 6, 2024

Description

Unable to import Crypto Wallets during new onboarding

Steps to Reproduce

  1. Enable Crypto Wallets via flag and set default Ethereum to Crypto Wallets (depricated
  2. Create Crypto Wallet after component is downloaded
  3. Set default to Extensions (Brave Wallet fallback)
  4. Initiate onboarding and select Already have a wallet
  5. Continue onboarding doesn't detect Deprecated wallet
  6. Repeat same steps with MetaMask
  7. Detects Metamask for import

Actual result:

Deprecated.Wallet.import.mp4

Expected result:

Should show similar to MM import
MM Import

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.67.69 Chromium: 125.0.6422.26 (Official Build) nightly (64-bit)
Revision 3ac44647a57f1d97bd6f702b5c13fd134a352079
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @muliswilliam
@srirambv srirambv mentioned this issue May 6, 2024
Closed
@jamesmudgett jamesmudgett added the priority/P2 A bad problem. We might uplift this to the next planned release. label May 10, 2024
@muliswilliam muliswilliam mentioned this issue May 13, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 14, 2024
@muliswilliam muliswilliam mentioned this issue May 16, 2024
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.67.93 or higher for 1.67.x verification 👍

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.67.98 Chromium: 125.0.6422.112 (Official Build) beta (64-bit)
Revision 9434daa5e8d2aceabb9cce574ab39429f2923b9b
OS Windows 11 Version 23H2 (Build 22631.3593)
  • Verified steps from issue description
  • Verified Legacy wallet import option is shown during onboarding
  • Verified able to import legacy wallet into new wallet without any issue
38074.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
bug feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
Web3
Status: Done
Milestone
1.67.x - Beta
Development

Successfully merging a pull request may close this issue.

fix(wallet): Fixed legacy wallet imports brave/brave-core
6 participants
@jamesmudgett @stephendonner @kjozwiak @srirambv @brave-builds @muliswilliam