Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Sometimes Play and Pause button are not responsive on NTT fullscreen video ad #37893

Closed
btlechowski opened this issue Apr 26, 2024 · 2 comments · Fixed by brave/brave-core#23372
Assignees
Labels
bug feature/ads OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-iPhone QA/Yes release-notes/exclude
Projects

Comments

@btlechowski
Copy link

btlechowski commented Apr 26, 2024

Follow up to #37653

Noticed that sometimes taping on Play or Pause button yielded no response.
The easiest way to reproduce is with the steps below

Steps to Reproduce

  1. Fresh install
  2. Turn off WiFi and mobile network
  3. Launch browser
  4. Toggle Use Staging CRX components in Settings -> BraveCore Switches
  5. Set rewards to staging
  6. Close the browser
  7. Turn on WiFi or mobile network
  8. Launch Brave browser
  9. Launch browser in Portrait orientation
  10. Open New Tab Pages until a tab with New Tab Takeover video ad is opened
  11. Wait till video stops playing
  12. Play the video in fullscreen
  13. Rapidly tap Play/Pause buttons

Note: issue not reproducible when taping on the video

Actual result:

Play and Pause button are not responsive

Expected result:

Play and Pause button are responsive, just like tapping next to the buttons

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

1.67.44 on iphone 13 pro max

cc @tmancey @aseren

@btlechowski btlechowski added bug release-notes/exclude feature/ads OS/iOS Fixes related to iOS browser functionality labels Apr 26, 2024
@tmancey tmancey added this to New issues in Ads Apr 26, 2024
@aseren aseren moved this from New issues to Priority in Ads Apr 30, 2024
@aseren aseren added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes labels Apr 30, 2024
@aseren aseren self-assigned this Apr 30, 2024
@aseren aseren moved this from Priority to In progress in Ads Apr 30, 2024
@aseren aseren moved this from In progress to Review in Ads May 1, 2024
Ads automation moved this from Review to Done May 1, 2024
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone May 1, 2024
@kjozwiak
Copy link
Member

kjozwiak commented May 8, 2024

The above requires 1.66.103 or higher for 1.66.x verification 👍

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 10, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented May 10, 2024

Verified on iPhone 12 running iOS 17.3.1 using version 1.66.104

Note: Additional testing was on iPhone and iPad was done via #36435 (comment) & #36435 (comment)

RPReplay_Final1715381540.MP4

@Uni-verse Uni-verse added QA Pass-iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/ads OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-iPhone QA/Yes release-notes/exclude
Projects
Ads
  
Done
5 participants