HTTPError should be unwrappable.

[cube2222]

Hey @bradleyfalzon!

Thanks for creating https://github.com/bradleyfalzon/ghinstallation!

An issue we've been having is that, when using a custom http client underneath ghinstallation and returning special error types from it, ghinstallation wraps them in HTTPError which we can't unwrap using errors.As.

Would you consider accepting this fix upstream?

[bradleyfalzon]

Yeah I think this is entirely reasonable.

Any chance on a small comment on Unwrap, like “Unwrap returns RootCause the underlying error”.

I also can’t see any tests for HTTPError, this looks like we never added one initially. Any chance you could spend a moment and add an appropriate test for the specific Unwrap method?

@wlynch any thoughts?

[cube2222]

@bradleyfalzon Sure, here you go.

[bradleyfalzon]

Thanks @cube2222, I’ll see if @wlynch has any comments if he has a moment, else I’ll merge in and tag in next few days, unless you’re in a rush.

[cube2222]

Awesome, thanks @bradleyfalzon! No rush, using our fork in the meantime.

[wlynch]

LGTM! Thanks for adding this!