Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trim trailing slashes from base url #57

Merged
merged 1 commit into from Nov 25, 2021
Merged

trim trailing slashes from base url #57

merged 1 commit into from Nov 25, 2021

Commits on Nov 25, 2021

  1. trim trailing slashes from base url 

    When using a custom Github URL (e.g. for a Github Enterprise instance)
one might specify it with a trailing slash. This can lead to URLs
containing two successive slashes.

Github will not ignore this, but instead return a HTTP 401 Forbidden
response. It might be nice to address the issue by removing trailing
slashes when joining with a string that has a leading slash.
    @0robustus1
    0robustus1 committed Nov 25, 2021
    Copy the full SHA
    2586ae4 View commit details
    Browse the repository at this point in the history