Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ID getter methods #103

Merged
merged 1 commit into from Jul 12, 2023

Conversation

carsonoid
Copy link
Contributor

Without this, it is not possible to know which app or installation a given transport is for without tracking it separately.

These are getter functions that return copies so they are backwards compatible and cannot cause any issues or break a transport.

Without this, it is not possible to know which app or installation a given transport is
for without tracking it separately.

These are getter functions that return copies so they are backwards compatible and cannot
cause any issues or break a transport.
@bradleyfalzon
Copy link
Owner

Thanks, this use case makes sense to me, as I can see someone may want to log the particular appId or similar when there's an error. Having a getter method makes sense instead of making it public due to the complexity involved in making that variable mutable. Also, thanks for the test.

@bradleyfalzon bradleyfalzon merged commit 97d7371 into bradleyfalzon:master Jul 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants