Fixes #2616: Update insecure minimist dependency version #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceCreamYou
added a commit
to IceCreamYou/check-dependencies
that referenced
this pull request
Apr 1, 2022
…ty until bower/bower#2617 merges and a new release comes out. Breaks bower support, but bower is obsolete.
|
@IceCreamYou the contributing guidelines specified a feature branch in the fork, not sure if the maintainers will consider master as a feature branch? |
|
The branch used in my fork makes no difference here. Feature branches are recommended because that'd be needed if I had multiple PRs open at once. |
|
semantics, they specifically ask that contributors create a new topic branch and I was trying to determine if that could be why this PR isn't being reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this security advisory: GHSA-xvch-5gv4-984h
I reviewed the commits between minimist versions and didn't see anything that looked like it would cause compatibility issues with the one place this dependency is used here, but I did not test exhaustively that the upgrade did not break things.