Do not store resolutions with force-latest when --dont-save-resolutions is used #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns is used Closes #2344 Without this, there's no way to prevent --force-latest from modifying bower.json when it resolves a conflict. This adds a --dont-save-resolutions to prevent that. Not sure this is the best way, but it's the compatible way :). Also, I have no idea how to get at the parsed options in Manager, directly looking at cooked argv is probably not the correct way..
|
I'm posting alternative solution that updates package.json only if --save is used: #2508 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2344
Without this, there's no way to prevent
--force-latestfrom modifying bower.json when it resolves a conflict.This adds a
--dont-save-resolutionsto prevent that.Not sure this is the best way, but it's the compatible way :).
Also, I have no idea how to get at the parsed options in
Manager, directly looking at cooked argv (this._config.argv.cooked) is probably not the correct way..Thoughts anyone? :)