Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the info command to accept @ as a divider #2320

Closed
wants to merge 2 commits into from
Closed

Allow the info command to accept @ as a divider #2320

wants to merge 2 commits into from

Conversation

doomedramen
Copy link
Member

replace @ with # when the endpoint is received

replace @ with # when the endpoint is received
@doomedramen
Copy link
Member Author

The tricky bit is writing the tests ;)

@sheerun
Copy link
Contributor

sheerun commented Jul 1, 2016

Could you cover other commands as well before we merge? :)

@doomedramen
Copy link
Member Author

Sure, just need to figure out a good way to test bower install package@version then I will re merge.

On Fri, 1 Jul 2016, 18:43 Adam Stankiewicz, notifications@github.com
wrote:

Could you cover other commands as well before we merge? :)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2320 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAbODLu0oCZFk-UKrb_DMwL1JqTDsQ3Gks5qRVGngaJpZM4JDQWi
.

@sheerun
Copy link
Contributor

sheerun commented Jul 1, 2016

I've created dummy empty package: https://github.com/sheerun/empty

Maybe something like this will work?

        return helpers.run(install, [
            ['empty@1.0.1'], {
                save: true
            }
        ]).then(function () {
            ...
        });

@ is replaced with # as part of the `install` command.
@doomedramen doomedramen closed this Jul 4, 2016
@doomedramen
Copy link
Member Author

Cheers, now tidying up my changes and putting a new merge in

@doomedramen
Copy link
Member Author

replaced with merge: #2322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants