Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support single-char repo names and package names #2249

Merged
merged 1 commit into from Apr 12, 2016
Merged

Support single-char repo names and package names #2249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/commands/register.js
View file
Open in desktop
Expand Up @@ -9,7 +9,7 @@ function register(logger, name, source, config) {
var registryClient;
var force;
var url;
var githubSourceRegex = /^\w[\w-]+\/\w[\w-]+$/;
var githubSourceRegex = /^\w[\w-]*\/\w[\w-]*$/;
var getGithubUrl = function(source) {
return 'git@github.com:' + source + '.git';
};
Expand Down
17 changes: 15 additions & 2 deletions test/commands/register.js
View file
Open in desktop
Expand Up @@ -90,11 +90,24 @@ describe('bower register', function () {
mainPackage.prepare();

var register = registerFactory(mainPackage.path, mainPackage.meta());
return helpers.run(register, ['some-name', 'some-repo/package'])
return helpers.run(register, ['some-name', 'some-name/repo'])
.spread(function (result) {
expect(result).to.eql({
// Result from register action on stub
name: 'some-name', url: 'git@github.com:some-repo/package.git'
name: 'some-name', url: 'git@github.com:some-name/repo.git'
});
});
});

it('should support single-char github names', function () {
mainPackage.prepare();

var register = registerFactory(mainPackage.path, mainPackage.meta());
return helpers.run(register, ['some-name', 'a/b'])
.spread(function (result) {
expect(result).to.eql({
// Result from register action on stub
name: 'some-name', url: 'git@github.com:a/b.git'
});
});
});
Expand Down