postuninstall hook feature

[samjacobclift]

postuninstall hook for bower

See the original issue here #1451

Any and all feedback welcome!

[pertrai1]

@royka Can you check the failing build for your test?

[samjacobclift]

@pertrai1 Taken a look but I can reproduce the failing build, I've tried running the test suite with different node versions but can't see why the test fails in Travis

[faceleg]

@royka did you run it with node 4.2?

[samjacobclift]

ran it on node version 4.2.2 on OS X as well as 5.0. Just run grunt test right?

[samjacobclift]

just ran the tests on ubuntu:12.04 image with node version 4.2 test still passed

[samjacobclift]

also ran on windows 10 with node 5.0, maybe I'm missing something?

[sheerun]

Maybe it's some kind of race condition? ..

[sheerun]

@royka You need to wrap scripts.postuninstall in another function, just like here: https://github.com/royka/bower/blob/postuninstall-hook-feature/lib/core/Project.js#L109

That's how promises work.

Please also rebase on current master branch and force push changes. Thank you!

[sheerun]

Also, please add another test instead of modifying existing one :)

[samjacobclift]

Thanks @sheerun will update with the changes!

[samjacobclift]

Pushed the changes suggested test pass locally so waiting for CI to come back but all feedback is welcome, wanted and very much needed :)

[sheerun]

Unfortunately some Travis builds are still failing :) Also, could you squash all commits when they pass?

[samjacobclift]

Will get to work on this soon, sorry to leave it hanging!

[sheerun]

Hey. Any progress?

[sheerun]

Commited in #2252