add support for save and save-exact in .bowerrc #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The install command now supports designating "save" and "save-exact" values in .bowerrc. If the `--save` flag is not used, but the config file sets "save" to true, the command will behave as if the `--save` option was specified. The same is true of `--save-exact` if "save-exact" is set to true in `.bowerrc`. The uninstall command will also behave as if the `--save` flag had been specified if "save" is set to true in `.bowerrc`.
|
Awesome PR, thank you :) |
sheerun
added a commit
that referenced
this pull request
Jan 29, 2016
add support for save and save-exact in .bowerrc
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I'm a long-time fan and user or bower, first-time PRer. I am grateful to bower's maintainers, and I'd be glad for any feedback or suggestions.
This PR is in response to issue #1040, specifically comments from @svengt and @sheerun. It adds support for npm-like config setting set in
.bowerrc. When set to true, the "save" setting causes the install and uninstall commands to act as if the user had specified--save. Likewise, when set to true, the "save-exact" setting causes the install command to act as if the user had specified--save-exact. So as not to break the API, when set to false or omitted, these commands behave as before.One small note:
lib/commands/install.jsalready checked for a "default-save" setting. I'm not sure if this is documented anywhere, but I left it in place in case any users are depending on this.