Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--save by default #1040

Closed
sindresorhus opened this issue Jan 8, 2014 · 35 comments
Closed

--save by default #1040

sindresorhus opened this issue Jan 8, 2014 · 35 comments
Labels
enhancement

Comments

@sindresorhus
Copy link
Contributor

Since most people would want to save a dependency to bower.json when doing bower install <package> I suggest we make --save the default and introduce a --no-save flag. The default will only have an effect if there is a bower.json.
@addyosmani
Copy link
Member

👍

@xen
Copy link

xen commented Jan 9, 2014

Upvote 👍

@svnlto
Copy link
Member

svnlto commented Jan 9, 2014

👍

1 similar comment
@Anahkiasen
Copy link

👍

@sheerun
Copy link
Contributor

sheerun commented Jan 10, 2014

Of course this is 2.x feature as it breaks api.

@helmus
Copy link

helmus commented Jan 18, 2014

👍

1 similar comment
@hemanth
Copy link
Contributor

hemanth commented Jan 18, 2014

👍

@wibblymat
Copy link
Member

We could add a .bowerrc flag like save-by-default. Default to false now and flip to true for 2.x?

@sindresorhus
Copy link
Contributor Author

@wibblymat 👍

@gh-naylor
Copy link

+1

Would it possible to set this to --save to the <head> tag inside a given file? (index.html for example)

@sindresorhus
Copy link
Contributor Author

@gh-naylor no, that's a task for another tool.

@benschwarz
Copy link
Member

👍 To @wibblymat's proposal.
Flip to true for 2.x and then deprecate the .bowerrc option.

@wibblymat
Copy link
Member

PRs welcome ;)

wibblymat added a commit to wibblymat/bower that referenced this issue Jan 27, 2014
@wibblymat
Added a .bowerrc option to make bower install assume --save (bower#1040)
e6cb497
wibblymat added a commit that referenced this issue Jan 28, 2014
@wibblymat
Merge pull request #1074 from wibblymat/save-by-default
ef2f637 
Added a .bowerrc option to make bower install assume --save (#1040)
@ninjatronic
Copy link

I disagree. The --save option is consistent with other package managers (e.g. npm). Probably this change will be confusing to users.

@kevva
Copy link

kevva commented Mar 5, 2014

@ninjatronic, component for example is using --saveby default, and that's probably the intended behaviour in most cases, even though npm is not using it.

@benschwarz
Copy link
Member

Yeah, I think this is a solid change and we should move in that direction.
I don't care what other package managers do in this instance.

@Anahkiasen
Copy link

Composer saves packages by default, for the note.

@ninjatronic
Copy link

Worth noting then that uninstall should then also be expected to remove entries from the bower.json file

@fmalk
Copy link

fmalk commented Mar 20, 2014

👍

@sheerun sheerun mentioned this issue Apr 15, 2014
Closed
@apfelbox
Copy link

👍 (always annoyed that other package managers don't do the same)

@paulirish paulirish added this to the 2.0.0 milestone Apr 15, 2014
@paulirish
Copy link
Member

Added to 2.0 milestone.

We'll need to output some message indicating the bower.json has been updated.

@benschwarz benschwarz modified the milestones: 2.0.0, 1.3.2 Apr 16, 2014
@benschwarz benschwarz removed this from the 1.3.2 milestone Apr 16, 2014
@addyosmani addyosmani mentioned this issue Apr 19, 2014
Closed
@desandro desandro mentioned this issue May 12, 2014
Closed
@martinkr
Copy link

+1

4 similar comments
@chibicode
Copy link
Contributor

👍

@karin-n
Copy link

karin-n commented Jun 10, 2014

+1

@yumyo
Copy link

yumyo commented Sep 19, 2014

+1

@tannerhodges
Copy link

👍

@sindresorhus sindresorhus mentioned this issue Jan 19, 2015
Closed
@legshooter
Copy link

👍

@automatix
Copy link

+1 for save_by_default/save_dev_by_default (true|false, default = false) and --no-save/--no-save-dev.

@vedmant
Copy link

vedmant commented Jul 26, 2015

👍 I'm for this feature! Often forget to add --save, mostly I install package and want to save it to bower.json. Also I'm for removing .bowerrc and add directory option to bower.json, this really confused me when I learned Bower.

@ohcrider
Copy link

ohcrider commented Sep 1, 2015

👍

@svengt
Copy link

svengt commented Dec 2, 2015

I would suggest to make this configurable like npm does.

$ npm config set save=true
$ npm config set save-exact=true

http://blog.heroku.com/archives/2015/11/10/node-habits-2016#2-use-a-smart-npmrc

@sheerun
Copy link
Contributor

sheerun commented Dec 2, 2015

Good idea. I'll accept a PR enabling it for .bowerrc (with tests).

@blcook223 blcook223 mentioned this issue Jan 29, 2016
Merged
@benmann
Copy link
Member

benmann commented Mar 1, 2016

I feel like #2161 is not just a neat solution but also enough to close this issue.
cc: @sheerun agree?

@sheerun
Copy link
Contributor

sheerun commented Mar 1, 2016

yup :)

@sheerun sheerun closed this as completed Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests