New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postuninstall hook #1451
Comments
It's breaking change + We don't want bower to run this way |
Ok, so how to run something after component uninstall? |
Please read the hooks documentation: https://github.com/bower/bower/blob/master/HOOKS.md |
Just finished re-reading :) |
The issue description wasn't clear on that, so I assumed you just have problems with hooks in general or want to add "grunt" posthook by default. @sindresorhus Probably has an answer for your question as he implemented it. |
No idea. I didn't implement it. Though there probably should be a |
Definitely a +1 from me here. Wiredep suggests adding a |
👍 |
+1 |
It would definitely be nice to have this hook. 👍 |
+1 for me too, it would be great with wiredep |
+1 for me too. Would very nice. |
+1, simple automatisation and keeps things clean 👍 |
+1 |
+1 , esp. for the use-case of wiredep (so it can automatically remove all the script / css tags in your HTML files after Bower uninstalls a thing) |
+1, need |
Uh duh, yes we need this. If it will inject my css and js when I install something IT SHOULD remove it when I uninstall something. This just seems logical right? Am I missing something? I do appreciate all you do.. Just saying.. |
It's not as easy as you think to implement. PR with tests is appreciated :) |
I understand. There is probably something I don't know about. I totally get that. As a developer I am often asked to do something that is estimated to take only 4 hours, a couple weeks later we found out that really was not as easy as the business owner thought it would be |
+1 from me, too |
+1, though I found a temporary workaround using watch: {
bower: {
files: ['bower.json', '.bowerrc'],
tasks: ['wiredep']
}
} And of course you can add templating tasks after |
+1 for wiredep for me too! |
+1 for me, bower-requirejs user. I have to run bower-requirejs on every grunt build, but I'd much rather run it from a postuninstall hook. |
+1. This hook combined with wiredep would be very helpful when completing the workflow for uninstalling packages via bower. |
+1 for the postuninstall hook. |
I'll +1 this aswell -> don't really see how you implement a postinstall hook without a postuninstall 💃 |
I agree, +1 to postuninstall hook, i endorse this. |
+1 for the postuninstall hook. |
+1 |
4 similar comments
+1 |
+1 |
+1 |
+1 |
+1 :) |
+1 |
Implemented in #2252 and will be released in bower 1.8 |
Please
The text was updated successfully, but these errors were encountered: