Skip to content

Commit

Permalink
Support single-char repo names and package names (#2249)
Browse files Browse the repository at this point in the history
  • Loading branch information
rpunkfu authored and sheerun committed Apr 12, 2016
1 parent 8ee2d78 commit 40e3ee0
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/commands/register.js
Expand Up @@ -9,7 +9,7 @@ function register(logger, name, source, config) {
var registryClient;
var force;
var url;
var githubSourceRegex = /^\w[\w-]+\/\w[\w-]+$/;
var githubSourceRegex = /^\w[\w-]*\/\w[\w-]*$/;
var getGithubUrl = function(source) {
return 'git@github.com:' + source + '.git';
};
Expand Down
17 changes: 15 additions & 2 deletions test/commands/register.js
Expand Up @@ -90,11 +90,24 @@ describe('bower register', function () {
mainPackage.prepare();

var register = registerFactory(mainPackage.path, mainPackage.meta());
return helpers.run(register, ['some-name', 'some-repo/package'])
return helpers.run(register, ['some-name', 'some-name/repo'])
.spread(function (result) {
expect(result).to.eql({
// Result from register action on stub
name: 'some-name', url: 'git@github.com:some-repo/package.git'
name: 'some-name', url: 'git@github.com:some-name/repo.git'
});
});
});

it('should support single-char github names', function () {
mainPackage.prepare();

var register = registerFactory(mainPackage.path, mainPackage.meta());
return helpers.run(register, ['some-name', 'a/b'])
.spread(function (result) {
expect(result).to.eql({
// Result from register action on stub
name: 'some-name', url: 'git@github.com:a/b.git'
});
});
});
Expand Down

0 comments on commit 40e3ee0

Please sign in to comment.