Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust dependencies #1623

Merged
merged 8 commits into from
Jun 21, 2021
Merged

Update Rust dependencies #1623

merged 8 commits into from
Jun 21, 2021

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Jun 18, 2021

Description of changes:

b1614643 tools: cargo update

2ea330cc Update semver to 1.0
    This has to be done in the tools and sources workspaces simultaneously because
    of the updater dependency in pubsys.
    
    The semver parser changed, so some version values we considered "good" before
    (but didn't actually use) now fail to parse, and so were moved to the "bad"
    value unit test.

b5406bdb sources: cargo update
7b52c7de apiserver: update for actix-web 4.0.0-beta.6
af64e03d sources: update nix to 0.21
3279c077 sources: update darling
bf90d364 imdsclient: remove unused simplelog dependency
e8c95b66 ecs-settings-applier: remove unused model dependency

Not updated:

  • gptman
  • hyper (in sources/)
  • handlebars - lots of template breakage; we could adapt our templates to it, but they wouldn't look right, so I think it's better to wait for a resolution to that issue.

Big thanks to @webern for helping figure out the apiserver changes for actix 4.0.0-beta.6, and the issue with handlebars.

Testing done:

Unit tests pass. Built k8s and ECS AMIs. Confirmed systemctl status running, dmesg and journal OK. Ran a pod/task OK. Made API changes OK.

Confirmed that the API still returns our custom error codes and messages, after the changes required for actix.

Confirmed that cargo make repo and cargo make ssm still work OK.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@tjkirch tjkirch requested review from zmrow and webern and removed request for zmrow and webern June 18, 2021 16:59
@tjkirch
Copy link
Contributor Author

tjkirch commented Jun 18, 2021

(Sorry, didn't mean to assign reviewers yet. Testing should be done soon.)

@tjkirch tjkirch marked this pull request as ready for review June 18, 2021 17:18
@tjkirch tjkirch requested review from webern and zmrow June 18, 2021 17:18
@tjkirch
Copy link
Contributor Author

tjkirch commented Jun 18, 2021

Testing looked good, setting as ready for review.

@tjkirch
Copy link
Contributor Author

tjkirch commented Jun 21, 2021

I'm doing another quick cargo update of sources and tools to get the tokio 1.7.1 bugfix which might be important. Update coming soon.

tjkirch and others added 8 commits June 21, 2021 10:23
This has to be done in the tools and sources workspaces simultaneously because
of the updater dependency in pubsys.

The semver parser changed, so some version values we considered "good" before
(but didn't actually use) now fail to parse, and so were moved to the "bad"
value unit test.
Co-authored-by: Matthew James Briggs <brigmatt@amazon.com>
Co-authored-by: Tom Kirchner <tjk@amazon.com>
@tjkirch
Copy link
Contributor Author

tjkirch commented Jun 21, 2021

^ This push updates tokio, globset, and rustc-demangle (used by backtrace, in turn used by snafu) in the sources and tools crates. I didn't do a full cargo update because there was another backwards-incompatible actix beta release over the weekend and I don't want to bring in more changes right now.

Unit tests still pass, and I reconfirmed the above testing with an x86 aws-k8s-1.20 AMI.

@tjkirch tjkirch added this to the next milestone Jun 21, 2021
@tjkirch tjkirch merged commit ddc05be into bottlerocket-os:develop Jun 21, 2021
@tjkirch tjkirch deleted the rust-deps branch June 21, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants