Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube-rs: Bumps to 0.77 and creates explicit k8s client configs #373

Merged
merged 1 commit into from Dec 26, 2022

Conversation

jpmcb
Copy link
Contributor

@jpmcb jpmcb commented Dec 23, 2022

Issue number:

Closes: #371
Related to: kube-rs/kube#1109

Description of changes:

- Fixes breaking change from kube on how cluster URLs are derived and used 
  in kubes rustls-tls feature. Now, when we build the kubernetes clients, we explicitly
  derive the `kubernetes.default.svc` url via the `incluster_dns` config option.

Signed-off-by: John McBride <jpmmcb@amazon.com>

Testing done:

Integration tests on:

  • ipv4 馃憤馃徏
  • ipv6 馃憤馃徏

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

- Fixes breaking change from kube on how cluster URLs are derived and used in
  kubes rustls-tls feature. Now, when we build the kubernetes clients,
  we explicitly derive the `kubernetes.default.svc` url via the
  `incluster_dns` config option.

Signed-off-by: John McBride <jpmmcb@amazon.com>
Copy link
Contributor

@cbgbt cbgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job tracking that down!

@jpmcb jpmcb merged commit f69a170 into bottlerocket-os:develop Dec 26, 2022
@jpmcb jpmcb deleted the kube-bump branch December 26, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants