Makefile: aws-iam-authenticator 0.6.8 #805
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/a - related to GitHub rate limiting on
go mod vendor
-ing all the code within this image.Description of changes:
This patch is twofold:
(which mitigates issues building the older one with
direct
as the goproxysetting - see: [Bug]: Cannot build v0.6.2 using
GOPROXY
direct kubernetes-sigs/aws-iam-authenticator#586)kubernetes/kubernetes
: the upstream projectalready vends it's dependencies, so all we need to do is pass the
vendor
directory to the license checker. My theory on the rate limiting is that since
the docker container is using
https
to pull code throughgit
, we aregetting rate limited quickly. But since the majority of that code is in
kubernetes, we can skip this and avoid getting rate limited
Testing done:
Able to
make tools
without flakes.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.