Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: aws-iam-authenticator 0.6.8 #805

Closed
wants to merge 1 commit into from

Conversation

jpmcb
Copy link
Contributor

@jpmcb jpmcb commented Apr 6, 2023

Issue number:

N/a - related to GitHub rate limiting on go mod vendor-ing all the code within this image.

Description of changes:

Makefile: aws-iam-authenticator 0.6.8

- Skip vendoring kubernetes code explicitly

This patch is twofold:

  • Adds the new aws-iam-authenticator in the bottlerocket-lookaside-cache
    (which mitigates issues building the older one with direct as the goproxy
    setting - see: [Bug]: Cannot build v0.6.2 using GOPROXY direct kubernetes-sigs/aws-iam-authenticator#586)
  • Skips vendoring code from kubernetes/kubernetes: the upstream project
    already vends it's dependencies, so all we need to do is pass the vendor
    directory to the license checker. My theory on the rate limiting is that since
    the docker container is using https to pull code through git, we are
    getting rate limited quickly. But since the majority of that code is in
    kubernetes, we can skip this and avoid getting rate limited

Testing done:

Able to make tools without flakes.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

- Skip vendoring kubernetes code explicitly

Signed-off-by: John McBride <jpmmcb@amazon.com>
Copy link
Contributor

@ecpullen ecpullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until a full test has been done to ensure none of our agents are broken.
#390

@jpmcb
Copy link
Contributor Author

jpmcb commented Apr 6, 2023

The other alternative is to add a flip on GOPROXY to also use the upstream proxy and not just direct

@jpmcb
Copy link
Contributor Author

jpmcb commented Apr 13, 2023

Superseded by #810

@jpmcb jpmcb closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants