Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies: Switch from openssl to rustls #766

Merged
merged 7 commits into from
Apr 13, 2023
Merged

Dependencies: Switch from openssl to rustls #766

merged 7 commits into from
Apr 13, 2023

Conversation

ecpullen
Copy link
Contributor

@ecpullen ecpullen commented Feb 7, 2023 •
edited

Issue number:

N/A

Description of changes:

Switches from openssl-tls to rustls-tls.

Testing done:

Make images.
Tested with cargo make test

 NAME                                 TYPE        STATE       PASSED   SKIPPED   FAILED
 x86-64-aws-k8s-124                   Resource    completed
 x86-64-aws-k8s-124-instances-xzko    Resource    running
 x86-64-aws-k8s-124-quick             Test        pass        1        6972      0

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@ecpullen ecpullen requested review from webern, etungsten and mjsterckx and removed request for webern February 7, 2023 20:05
etungsten
etungsten approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@etungsten etungsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

jpmcb
jpmcb reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a few references still to OPENSSL_STATIC in the example agents:

bottlerocket-test-system/agent/resource-agent/examples/duplicator_resource_agent/Dockerfile

Line 11 in 53f319a

ENV OPENSSL_STATIC=true

probably makes sense to remove those too?

also this phony target to sdk-openssl doesn't seem relevant anymore?

bottlerocket-test-system/Makefile

Line 34 in 53f319a

.PHONY: build sdk-openssl example-test-agent example-test-agent-cli example-resource-agent \

@ecpullen ecpullen marked this pull request as draft February 7, 2023 22:21
@ecpullen ecpullen marked this pull request as ready for review April 12, 2023 16:54
jpmcb
jpmcb reviewed Apr 12, 2023
View reviewed changes
Copy link
Contributor

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could also remove this unused sdk-openssl .PHONY from the makefile:

bottlerocket-test-system/Makefile

Line 34 in df0c62d

.PHONY: build sdk-openssl example-test-agent example-test-agent-cli example-resource-agent \

.github/workflows/build.yaml Outdated Show resolved Hide resolved
deny.toml Outdated Show resolved Hide resolved
@ecpullen ecpullen merged commit ff38687 into bottlerocket-os:develop Apr 13, 2023
3 checks passed
@ecpullen ecpullen deleted the updates branch April 13, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjsterckx mjsterckx mjsterckx approved these changes

@jpmcb jpmcb jpmcb approved these changes

@etungsten etungsten etungsten approved these changes

@webern webern Awaiting requested review from webern

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ecpullen @mjsterckx @jpmcb @etungsten