Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: switch to new SDK with openssl #118

Merged
merged 2 commits into from Oct 27, 2021
Merged

build: switch to new SDK with openssl #118

merged 2 commits into from Oct 27, 2021

Conversation

etungsten
Copy link
Contributor

Issue number:
Addresses #105

Description of changes:
Implements changes from bcressey/bottlerocket-update-operator@4679360b
but for testsys.

Testing done:
Letting github actions test this.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Member

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Is the fetch target hygienic, or is it needed to make things work?

@etungsten
Copy link
Contributor Author

Nice. Is the fetch target hygienic, or is it needed to make things work?

It makes it so that we would never have to fetch crate dependencies in the build container. Incremental builds would be much faster.

@webern
Copy link
Member

webern commented Oct 27, 2021

New SDK is available :shipit:

@etungsten etungsten marked this pull request as ready for review October 27, 2021 19:57
@etungsten
Copy link
Contributor Author

Push above switches from the beta sdk to the released v0.23.0 SDK version

@etungsten etungsten merged commit 6eb320b into develop Oct 27, 2021
@etungsten etungsten deleted the sdk-openssl branch October 27, 2021 21:08
@webern webern mentioned this pull request Oct 28, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants