Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move testing dependencies to workspace and bump dependencies #552

Merged
merged 4 commits into from Apr 6, 2020

Conversation

chentsulin
Copy link
Member

@chentsulin chentsulin commented Apr 6, 2020

Due to the axios PR (axios/axios#2391) introduced in axios v1.19.1, we need to modify the config.url assertions to exclude baseURL.

@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #552 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #552   +/-   ##
=======================================
  Coverage   90.59%   90.59%           
=======================================
  Files          25       25           
  Lines        1510     1510           
  Branches      427      427           
=======================================
  Hits         1368     1368           
  Misses         98       98           
  Partials       44       44           
Impacted Files Coverage Δ
packages/messaging-api-line/src/LineNotify.ts 80.00% <ø> (ø)
packages/messaging-api-common/src/case.ts 97.56% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 011d744...1f74110. Read the comment docs.

@chentsulin chentsulin merged commit 5a9bed2 into master Apr 6, 2020
@chentsulin chentsulin deleted the move-test-deps-workspace branch April 6, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant