Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: random crashes in credentials.py #2946

Merged
merged 1 commit into from Jul 30, 2023
Merged

fix: random crashes in credentials.py #2946

merged 1 commit into from Jul 30, 2023

Conversation

markste-in
Copy link
Contributor

os.path.sep and os.sep are supposed to do the same but os.path.sep can lead to random crashes in newer python versions with the following error

AttributeError: module 'posixpath' has no attribute 'sep'

This is also known to other projects and is caused by some broken python versions

pytest-dev/pytest#10547
Toblerity/Fiona#1143
pallets/jinja#1697

The small proposed fix will avoid the issue altogether, even with broken python versions

os.path.sep and os.sep are supposed to do the same but os.path.sep can lead to random crashes in newer python versions
@nateprewitt
Copy link
Contributor

Thanks for the report, @markste-in. It's not clear for the other issues why this is happening. All the explanation appear vague. I don't think this is an unreasonable change though. I'm going to close/open the issue to get CI running since it appears to have not run when you opened the PR. We'll take a closer look after that finishes.

@nateprewitt nateprewitt reopened this Jul 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09% 🎉

Comparison is base (97ba590) 93.29% compared to head (bc69c32) 93.39%.
Report is 209 commits behind head on develop.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2946      +/-   ##
===========================================
+ Coverage    93.29%   93.39%   +0.09%     
===========================================
  Files           64       66       +2     
  Lines        13588    13957     +369     
===========================================
+ Hits         12677    13035     +358     
- Misses         911      922      +11     
Files Changed Coverage Δ
botocore/credentials.py 98.43% <100.00%> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @markste-in!

@nateprewitt nateprewitt merged commit b1238b3 into boto:develop Jul 30, 2023
34 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Jul 31, 2023
* release-1.31.16:
  Bumping version to 1.31.16
  Update to latest partitions and endpoints
  Update to latest models
  fix: random crashes in credentials.py (#2946)
  Avoid a KeyError when a ComponentLocator is being called concurrently (#2985)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants