Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExtraArgs supported by Bucket.copy #3172

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions boto3/s3/inject.py
Expand Up @@ -406,8 +406,8 @@ def copy(

:type ExtraArgs: dict
:param ExtraArgs: Extra arguments that may be passed to the
client operation. For allowed download arguments see
boto3.s3.transfer.S3Transfer.ALLOWED_DOWNLOAD_ARGS.
client operation. For allowed copy arguments see
boto3.s3.transfer.S3Transfer.ALLOWED_COPY_ARGS.

:type Callback: function
:param Callback: A method which takes a number of bytes transferred to
Expand Down Expand Up @@ -544,8 +544,8 @@ def object_copy(

:type ExtraArgs: dict
:param ExtraArgs: Extra arguments that may be passed to the
client operation. For allowed download arguments see
boto3.s3.transfer.S3Transfer.ALLOWED_DOWNLOAD_ARGS.
client operation. For allowed copy arguments see
boto3.s3.transfer.S3Transfer.ALLOWED_COPY_ARGS.

:type Callback: function
:param Callback: A method which takes a number of bytes transferred to
Expand Down
1 change: 1 addition & 0 deletions boto3/s3/transfer.py
Expand Up @@ -243,6 +243,7 @@ def __setattr__(self, name, value):

class S3Transfer:
ALLOWED_DOWNLOAD_ARGS = TransferManager.ALLOWED_DOWNLOAD_ARGS
ALLOWED_COPY_ARGS = TransferManager.ALLOWED_COPY_ARGS
ALLOWED_UPLOAD_ARGS = TransferManager.ALLOWED_UPLOAD_ARGS

def __init__(self, client=None, config=None, osutil=None, manager=None):
Expand Down