New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 upload_file, download file to support path-lib objects #2259
Merged
Merged
Changes from 23 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
ada17c6
Update transfer.py
alanyee ef141cb
Update transfer.py
alanyee b25cdff
Add exhaustive ValueError message
alanyee fa917ec
Update test_transfer.py
alanyee 86053f2
Fix test for download
alanyee 6b84c21
Correct file path for Windows
alanyee 351a7a5
Add os import for unit tests
alanyee 049b10a
Fix for Windows
alanyee 6cf1f6c
Fix for Windows path
alanyee aa4d6bf
Merge branch 'develop' into patch-1
alanyee ab9643b
Merge branch 'develop' into patch-1
alanyee eb43aaf
lint: fix style
alanyee be73d95
lint: fix style
alanyee 6108d6f
lint: fix style
alanyee 0970707
lint: fix style
alanyee 38962ec
refactor: remove python2 compatibility
alanyee ff0af1b
fix: add os import when needed
alanyee 7f67c6f
test: add more unit and integration tests
alanyee 3d1bdc4
test: fix dupe function call
alanyee 1d05811
lint: fix linting issues
alanyee 39b183d
lint: add ending comma
alanyee fc84da5
fix: correct path import
alanyee bc6cae2
fix: add os check on os-dependent tests
alanyee 6257495
test: remove system dependent tests
alanyee 2efe07e
lint: remove unused import os
alanyee 5a7f0a8
feat: use feature that ensures system independent solution
alanyee ec0fde5
Revert "feat: use feature that ensures system independent solution"
jonemo 4ef8361
use NamedTempFile as source of realistic file name
jonemo b5da19b
actually use Path object in test_upload_via_path
jonemo 8a6365e
Merge branch 'develop' into patch-1
jonemo b12faf9
changelog
jonemo File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is
os.path.normpath
needed here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested it now, but the keys can be messed up on Windows:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add
normpath
to ensure it is properly encoded independent of the system.