Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Issue #3544 #3885

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Issue #3544 #3885

wants to merge 2 commits into from

Conversation

cvesay
Copy link

@cvesay cvesay commented Sep 26, 2019

  • boto\mws\connection.py
    • Corrected String != Bytes assertion bug in get_report. Based on suggested fix by @listingmirror.

* `mws\connection.py`
    * Corrected String != Bytes assertion bug in `get_report`.  Based on suggested fix by @listingmirror.
@cvesay
Copy link
Author

cvesay commented Sep 26, 2019

Updated the patch to include all additional updates made up through v2.49.0

@cvesay
Copy link
Author

cvesay commented Sep 26, 2019

#3880 (comment)

@cvesay
Copy link
Author

cvesay commented Sep 26, 2019

Package can be installed as a dependency through setuptools.

install_requires=[
        'boto @ https://github.com/cvesay/boto/archive/develop.zip#egg=boto-2.49.1',
        .
        .
        .
]

    * Updated `_parse_repsonse` to return the `body` when the `parser` has the `GetReportResult` attribute, allowing for XML file downloads.
@cvesay
Copy link
Author

cvesay commented Sep 26, 2019

Added some logic to return a XML body when requesting an XML report from MWS. There was a bug with properly parsing an XML file, would only return the last element in the list

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant