EIP-02M: Remediate Improper Domain Separator Retrieval #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliffhall
suggested changes
Sep 21, 2022
contracts/domain/BosonConstants.sol
Outdated
| @@ -158,6 +158,8 @@ string constant ESCALATION_NOT_ALLOWED = "Disputes without dispute resolver cann | |||
| string constant FEE_PERCENTAGE_INVALID = "Percentage representation must be less than 10000"; | |||
|
|
|||
| // EIP712Lib | |||
| string constant PROTOCOL_NAME = "BosonProtocolDiamond"; | |||
| string constant PROTOCOL_VERSION = "V1"; | |||
There was a problem hiding this comment.
We had decided that "V1" made sense as the first version of the BosonProtocolDiamond. But if we're calling it PROTOCOL_VERSION then it's confusing to call it V1 here.
Let's change PROTOCOL_NAME to "Boson Protocol" and PROTOCOL_VERSION to "V2"
This makes more sense in keeping with
bidyut-arianelabs
force-pushed
the
EIP-02M-improper-domain-separator-retrieval
branch
from
ee4ae73
to
5276bfd
Compare
hswopeams
suggested changes
Sep 22, 2022
zajck
requested changes
Sep 23, 2022
…ent chain id and earlier chain id
bidyut-arianelabs
force-pushed
the
EIP-02M-improper-domain-separator-retrieval
branch
from
5276bfd
to
59cd7dd
Compare
hswopeams
suggested changes
Sep 23, 2022
zajck
requested changes
Sep 23, 2022
hswopeams
approved these changes
Sep 23, 2022
zajck
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #321