Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CDK to v2 #1452

Closed
wants to merge 1 commit into from
Closed

Upgrade CDK to v2 #1452

wants to merge 1 commit into from

Conversation

javiertoledo
Copy link
Member

@javiertoledo javiertoledo commented Oct 3, 2023

Description

This is an exploration branch to upgrade the CDK to v2 for AWS.

Update: The CDK v2 comes with major changes in how CDK applications are handled. The CDKToolkit has been extracted into a CLI tool, so upgrading to v2 would force us to rewrite a significant portion of our deployment and nuke scripts, and the new implementation would require either running shell commands or using alpha packages. Given the situation, we want to explore the cost of migrating the AWS provider to the CDKTF before going further on this path.

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

@javiertoledo javiertoledo added do not merge This PR can be approved, but not merged yet maintainance dev-experience Developer Experience difficulty: high provider:aws Related to the AWS cloud provider labels Oct 3, 2023
@javiertoledo javiertoledo self-assigned this Oct 3, 2023
@ghost
Copy link

ghost commented Oct 3, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Oops, looks like you forgot to add a changeset.

⚠️ Please run rush change and commit the changeset file.

This command will prompt you for a change description and generate a changeset file. You can read more about changesets here.

Remember that you should use the version bump that is appropriate for the change you are making:

Version bump Meaning
patch Bug fixes, documentation changes, etc.
minor New features, non-breaking changes
major Breaking changes

If you are unsure about which version bump to use, please ask in the comments and we will help you out.

@javiertoledo javiertoledo changed the base branch from main to upgrade/node-18 October 4, 2023 19:53
@javiertoledo javiertoledo modified the milestones: v0.12.0, v2.x.x - Next major version Oct 8, 2023
@javiertoledo javiertoledo changed the base branch from upgrade/node-18 to v2.x.x October 8, 2023 10:54
@javiertoledo javiertoledo force-pushed the upgrade/cdk-v2 branch 2 times, most recently from c453788 to 0ad74bb Compare October 17, 2023 23:12
@javiertoledo
Copy link
Member Author

Closing as this no longer seem to make sense for the future of the project. See #1477 for more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-experience Developer Experience difficulty: high do not merge This PR can be approved, but not merged yet maintainance provider:aws Related to the AWS cloud provider spike
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant