Update chai #1780
Merged
Update chai #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Note that there's currently a bug with the 4.1.x versions where a failure in an expect will leak a variable to the global scope, causing mocha to report that leak instead of the actual failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Update chai to a more recent version. This required a small change in one of the test helpers.
Motivation
David was showing it as outdated with a red semaphore and everything which made me sad 馃槩
Proposed solution
Unfortunately we can't update to the more recent version (4.1.2) due to a bug in that version that causes the wrong error to be reported when an
expect()fails.The
countModels()test helper method had to be changed to do type coercion fromstringtonumber. This wasn't a problem before because chai did this coercion itself in thewithin,above,least,below,most,increaseanddecreasemethods, but that changed with version 4.0.0.Current PR Issues
Not the most recent version, but close enough.