Some small fixes #862
Merged
Some small fixes #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Privilege elevation can occur through pkexec, where many environment variables are not accessible. This fixes the following problem - if howdy-gtk is run without sudo, authorization occurs via pkexec, and the user variable is empty. So when adding the first model, it is unclear to which user to add it.
In some GTK themes, when we change a slide, we see a blank window because there is nothing to trigger the size update, and the slide is displayed at zero size. Let's force a size update so that it always works.
The "Video" tab layout did not display correctly when resizing the window.
The list of users may be empty, and if you try to add a model, a string concatenation error with None will occur. For simplicity and consistency with the "Delete" button, we simply check the size of the list after clicking.
Otherwise, when trying to read the /dev/v4l/by-path directory, an exception is thrown and the program visually freezes.
musikid
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some fixes, they are not particularly related in meaning, I combined them into one PR so as not to spam PRs. Descriptions are available in the corresponding commits.