Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add meson build system #803

Merged
merged 31 commits into from Sep 14, 2023
Merged

build: add meson build system #803

merged 31 commits into from Sep 14, 2023

Conversation

musikid
Copy link
Collaborator

@musikid musikid commented Jun 19, 2023

Based on #773, add Meson as a build system for the whole howdy package,
which allows better flexibility for the paths' configuration.
Generate a python module,
which contains the paths used by the other modules,
by using PurePath to simplify path concatenation and limit errors,
and the header containing the paths for the PAM module.

Closes #836

@boltgolt
Copy link
Owner

Lovely! I would say this supersedes the other path PR #773?

@musikid musikid marked this pull request as ready for review June 25, 2023 16:22
@musikid
Copy link
Collaborator Author

musikid commented Jun 25, 2023

Yes, it includes the commit from the other PR and takes it a step further with Meson.

@musikid musikid marked this pull request as draft June 25, 2023 16:34
@musikid
Copy link
Collaborator Author

musikid commented Jun 25, 2023

Should we first merge this PR and progressively create the remaining parts on other PRs, or merge all the changes on this one? Because I'm not sure if you will be able to review if I don't split the changes.

@musikid musikid marked this pull request as ready for review July 2, 2023 13:03
@boltgolt
Copy link
Owner

boltgolt commented Sep 5, 2023

Amazing, i've merged beta into your branch and that should hopefully be clean now. Any other PRs that i merge i'll make sure will use your new path factory system. Please check if my merge commit did not fuck anything up, and as i've made you collaborator you should be able to merge it yourself if it's all good! Thanks for all you do for Howdy!

@boltgolt boltgolt added this to the Release 3.0.0 milestone Sep 5, 2023
@musikid
Copy link
Collaborator Author

musikid commented Sep 6, 2023

Amazing, i've merged beta into your branch and that should hopefully be clean now. Any other PRs that i merge i'll make sure will use your new path factory system. Please check if my merge commit did not fuck anything up, and as i've made you collaborator you should be able to merge it yourself if it's all good! Thanks for all you do for Howdy!

Thanks, you're welcome!

@musikid
Copy link
Collaborator Author

musikid commented Sep 12, 2023

I added the latest changes for user model checking and fixed all the remaining problems, it can be now merged!

@boltgolt boltgolt merged commit 95df4d2 into boltgolt:beta Sep 14, 2023
1 check passed
@boltgolt
Copy link
Owner

Merged 🎉 Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beta crashes with no face model known
3 participants