Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Fix Sass Loader in Build Tools (Duplicate of #1361) #1362

Merged
merged 6 commits into from Aug 27, 2019

Conversation

sghoweri
Copy link
Contributor

Jira

http://vjira2:8080/browse/BDS-1794

Summary

Hotfix to the Bolt build tools to address a recent Sass Loader config change (when the Webpack build is compiling for production) that started causing recent Bolt builds on Travis to fail.

Details

One of the Bolt build tool dependencies (Sass Loader, used in our Webpack build) very recently introduced a "seemingly small" change that unfortunately has started to cause our Travis builds to start to fail and started failing downstream as reported this morning (likely due to fresher installs / NPM caches expiring and pulling in the more recent Sass Loader version).

Thankfully the fix seems to our Webpack configuration seems to be quite small but still requires a Bolt hotfix to ensure that this issue is patched before any older cached versions of this dependency get updated and builds start to fail across the board.
 
image

image

@sghoweri sghoweri merged commit 4b0db7d into master Aug 27, 2019
@sghoweri sghoweri deleted the fix/sass-build-issues branch August 27, 2019 19:32
@sghoweri sghoweri mentioned this pull request Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants