v2.5.7 Build Tools Hotfix #1361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to address a recent Sass Loader upstream change + update CLI to force i18n to be enabled by default for prod builds if otherwise undefined
sghoweri
changed the title
christophersmith262
approved these changes
Aug 27, 2019
|
FYI this PR was branched off of the v2.5.6 tag -- hence why a few of the build steps on this PR failed when pointing to the v2.6.0-beta.1 code (on the release branch) but the actual Travis build passed without any issues: https://travis-ci.com/bolt-design-system/bolt/builds/124743235 |
|
Closing this out -- v2.5.7 has been released with this hotfix and v2.6.0-beta.2 (with the same updates) is rolling out the door -- both releases will be announced shortly! CC @margoromo |
sghoweri
added a commit
that referenced
this pull request
Aug 27, 2019
… to address a recent Sass Loader upstream change. port of #1361 for the v2.6.0-beta.2 release
sghoweri
added a commit
that referenced
this pull request
Aug 27, 2019
Hotfix: Fix Sass Loader in Build Tools (Duplicate of #1361)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
http://vjira2:8080/browse/BDS-1794
Summary
Hotfix to the Bolt build tools to address a recent Sass Loader config change (when the Webpack build is compiling for production) that started causing recent Bolt builds on Travis to fail.
Details
One of the Bolt build tool dependencies (Sass Loader, used in our Webpack build) very recently introduced a "seemingly small" change that unfortunately has started to cause our Travis builds to start to fail and started failing downstream as reported this morning (likely due to fresher installs / NPM caches expiring and pulling in the more recent Sass Loader version).
Thankfully the fix seems to our Webpack configuration seems to be quite small but still requires a Bolt hotfix to ensure that this issue is patched before any older cached versions of this dependency get updated and builds start to fail across the board.
