Allow sensio/framework-extra-bundle version 6
#2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @bobvandevijver 👋 I personally don't like Shouldn't we just bump it to |
|
Hi 👋 Bumping it to 6.1 is fine by me 👍🏻 |
|
Cool! If tests are passing, I'll merge it in. Thanks! |
|
You might want to squash it before merge (if that isn't enabled by default), as two commits for this change might be a bit too much 😅 |
bobdenotter
approved these changes
Apr 27, 2021
|
Done, thanks again! 👍 |
bobdenotter
changed the title
sensio/framework-extra-bundle version 6
napley
pushed a commit
to novaway/core
that referenced
this pull request
May 19, 2021
* Allow sensio/framework-extra-bundle version 6 * Bump sensio/framework-extra-bundle to 6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if PSR-7 is actually used by this bundle, but that is the only major change between v5 en v6 of
sensio/framework-extra-bundle(see sensiolabs/SensioFrameworkExtraBundle#710 / https://github.com/sensiolabs/SensioFrameworkExtraBundle/blob/master/CHANGELOG.md).It seems to work fine for me when forcing composer to install v6.1.2.