Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❤️ package.json #32

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

❤️ package.json #32

wants to merge 5 commits into from

Conversation

lropero
Copy link

@lropero lropero commented Nov 13, 2022

  • Updated dependencies + added audit and sort scripts to package.json

@bokub
Copy link
Owner

bokub commented Nov 13, 2022

OK, but why?

@lropero
Copy link
Author

lropero commented Nov 13, 2022

Why not?

@lropero
Copy link
Author

lropero commented Nov 13, 2022

image

I'm using chalk-animation in upgradeps and see the audit, poor chalk-animation there with 2 major dependencies behind 😢

@lropero
Copy link
Author

lropero commented Nov 13, 2022

I removed sort script but leave you the tip: feel free to run npx sort-package-json to sort out package.json.

Btw I used Node v16.14.2 and npm v8.5.0 to generate lock file.

Cheers.-

@bokub
Copy link
Owner

bokub commented Nov 13, 2022

This module runs with Node versions as low as version 12.

Upgrading dependencies breaks this compatibility (you can see the tests failing)

@lropero
Copy link
Author

lropero commented Nov 13, 2022

Fixed, ava v5 dev dependency was breaking it, downgraded it to latest v4.

@lropero
Copy link
Author

lropero commented Nov 13, 2022

Tested everything with Node v12 and had to downgrade meow as well to latest v10 as cli.js was failing to run.

@codecov-commenter
Copy link

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (32c6d6a) compared to base (a1de903).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #32   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          194       194           
=========================================
  Hits           194       194           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants