Restore support for relative font size units #11397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattpap
force-pushed
the
mattpap/11110_em_font_size
branch
from
f2ea801
to
1638970
Compare
mattpap
added
status: ready
status: accepted
and removed
status: WIP
status: ready
labels
10 tasks
mattpap
added a commit
that referenced
this pull request
Jul 2, 2021
* Restore support for relative font size units * Add visual regression tests
mattpap
added a commit
that referenced
this pull request
Jul 5, 2021
* Upgrade to Chrome 91 and fix failing examples' tests (#11320) * Show version number in test:{run,spawn}:headless * Don't assume style.margin* are defined * Prefer chrome over chromium * Update baselines * Fix rendering of legends for ellipse glyph (#11368) * Handle corner cases in LinearLinterpolationScale.v_compute() (#11370) * Fix data access layout `SpatialIndex.bounds()` (#11379) * Fix data access layout SpatialIndex.bounds() * Resolve mypy's errors with numpy >= 1.21 * app_index.html missing quotes in href attribute (#11385) * Use an exact extension's version in a CDN URL (#11387) * Allow to scroll to the initial active tab (#11391) * Allow to scroll to the initial active tab * Add visual tests * Restore support for relative font size units (#11397) * Restore support for relative font size units * Add visual regression tests * Don't configure `z-index` on root elements (#11388) * Don't configure z-index on root elements * Add visual regression tests * Revert layout to pre PR #10779 state (#11394) * Revert layout regression fixes * Revert color bar layout related changes * Work around Grid's alignment bugs and limitations * Resolve mypy's complaints Co-authored-by: Dan Lester <dan@ideonate.com>
bryevdv
pushed a commit
that referenced
this pull request
Dec 13, 2021
* Restore support for relative font size units * Add visual regression tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only restores support for em size units. If fact it's better than the original, because it respects CSS of the canvas and its parent elements. Originally, the base font was derived from
.bk-root, ignoring any further styling. Other relative units may work to some extent, but not necessarily in a meaningful way. This will hopefully be addressed in 3.0.fixes #11110