Update to isort 5.8 #11204
Merged
Update to isort 5.8 #11204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattpap
reviewed
Apr 26, 2021
mattpap
reviewed
Apr 26, 2021
Well, I would actually merge this sooner than later. I don't see too many PRs where this would be particularly conflicting. |
bryevdv
force-pushed
the
bryanv/10287_isort
branch
from
a4532bb
to
825de7f
Compare
|
@mattpap I've pushed a change with a wrap limit of 4 imports you can see if you like better. |
|
I personally think the new value (4) is better |
mattpap
reviewed
Apr 27, 2021
mattpap
reviewed
Apr 27, 2021
Co-authored-by: Mateusz Paprocki <mattpap@gmail.com>
|
FYI I did have some conflicts rebasing this on latest, so I'd like to go ahead and merge this as-is and punt on any question or the docs/examples (if it is really a concern, an issue can be opened). |
bryevdv
added a commit
that referenced
this pull request
Dec 13, 2021
* update examples * use conda for 3.9 now * use force_grid_wrap=4 * remove profile * Update bokeh/util/string.py Co-authored-by: Mateusz Paprocki <mattpap@gmail.com> * add missing boilerplate Co-authored-by: Mateusz Paprocki <mattpap@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few comments on goals:
.isort.cfgfiles as nearly identical as possibleexamplesandsphinxare identical, and a restricted to line length 88 since they need to be formatted in docsbokehandreleaseare identical, andtestalmost so (it needs specual adds for local imports)bokeh,release, andtestfor consistency, but I really don't like super long import lines. I do not ever want to to have to scroll horizontally to see imports. I usedforce_grid_wrap=5which is not perfect, but seems OK@mattpap we don't have to merge this especially soon, while so many PRs are in flight. But I did want to nail down a workable configuration (will keep looking for any tweaks to improve this as well)