[PLAT-1264]: Upgrade snap-style Rubocop Version to 1.22.3+ #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenmagid
commented
Jan 9, 2024
rubocop/rubocop.yml
Outdated
| @@ -169,3 +169,186 @@ Layout/EmptyLineAfterGuardClause: | |||
|
|
|||
| Migration/DepartmentName: | |||
| Enabled: false | |||
|
|
|||
| # The following cops were added between 0.92.0 and 1.14.0 | |||
There was a problem hiding this comment.
These are all new cops that were added or enabled since Rubocop 0.92.0. I've gone ahead and disabled them until further review.
|
I was beat to the punch: #10 |
petermarathas
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes https://snapsheettech.atlassian.net/browse/PLAT-1264 by upgrading Rubocop to 1.22.3.
snap-styleisn't compatible with Ruby 3.1:Why
Version constraint defined on the
rubocopdependency is too strict and doesn't allow more recent versions. 1.14 is compatible with Ruby 3.1, but that introduced an issue that isn't fixed until 1.22.3.How
Relax constraint to allow the use of a newer version supporting Ruby 3.1.