Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #454: RSyntaxDocument#getTokenListForLine not final #455

Closed
wants to merge 1 commit into from
Closed

Fix for #454: RSyntaxDocument#getTokenListForLine not final #455

wants to merge 1 commit into from

Conversation

Hellwig-SE
Copy link

See issue #454 for an explanation

@codecov-commenter
Copy link

Codecov Report

Merging #455 (d36c97d) into master (27f2347) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #455      +/-   ##
============================================
+ Coverage     73.10%   73.12%   +0.02%     
- Complexity     6271     6274       +3     
============================================
  Files           169      169              
  Lines         28853    28853              
  Branches       3782     3782              
============================================
+ Hits          21094    21100       +6     
+ Misses         5951     5945       -6     
  Partials       1808     1808              
Impacted Files Coverage Δ
...a/org/fife/ui/rsyntaxtextarea/RSyntaxDocument.java 86.18% <ø> (ø)
...g/fife/ui/rsyntaxtextarea/MatchedBracketPopup.java 70.10% <0.00%> (-2.07%) ⬇️
.../java/org/fife/ui/rtextarea/ConfigurableCaret.java 71.17% <0.00%> (+0.43%) ⬆️
...a/org/fife/ui/rtextarea/ClipboardHistoryPopup.java 57.95% <0.00%> (+3.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f2347...d36c97d. Read the comment docs.

@Hellwig-SE
Copy link
Author

Hellwig-SE commented Sep 18, 2022

Fixed without PR, see 95e9072

@Hellwig-SE Hellwig-SE closed this Sep 18, 2022
@bobbylight
Copy link
Owner

Oh sorry @Hellwig-SE , I didn’t see there was a corresponding PR for the ticket yesterday! Otherwise I would have just merged this.

@Hellwig-SE
Copy link
Author

No problem and thanks for fixing #454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants