Add support for jupyter notebook #210
Conversation
pakio
force-pushed
the
add_notebook_support
branch
from
5d57b4e
to
7fb8d45
Compare
| @@ -17,7 +17,7 @@ | |||
| history = history_file.read().replace('.. :changelog:', '') | |||
|
|
|||
| requirements = [ | |||
| 'docopt', 'yarg' | |||
| 'docopt', 'yarg', 'nbconvert', 'ipython' | |||
There was a problem hiding this comment.
I would make jupyter support optional via extras: https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#optional-dependencies
pakio
force-pushed
the
add_notebook_support
branch
from
fe5b758
to
f633fcf
Compare
|
Hi @jamesmyatt cc @alan-barzilay , sorry for being stale for a long time. I just started to work on it again, but seeing an issue related to Do you have any plan to stop supporting python3.6 in the near future? |
|
Im not a maintainer but Python 3.6 is EOL so dropping support makes sense. Pereonally I'm in favour of small projects like this only supporting relatively few python versions for new releases. For example big projects often support 42 months of releases, like NEP29. But I would do less here. Remember that maintainers are volunteers. If I were you, I'd remove 3.6 and possibly 3.7 if it makes it easier, and then ask if it's OK. Worst that can happen is you'll be asked to update it. Remember it's easier to ask forgiveness. |
Commit rebased from bndr#210 . Credits to: pakio https://github.com/pakio
Commit rebased from bndr#210 . Credits to: pakio https://github.com/pakio
Commit rebased from bndr#210 . Credits to: pakio https://github.com/pakio
Commit rebased from bndr#210 . Credits to: pakio https://github.com/pakio fix coverage report bug updated nbconvert version fixed lint issues add black formatting rules
Commit rebased from bndr#210 . Credits to: pakio https://github.com/pakio fix coverage report bug updated nbconvert version fixed lint issues add black formatting rules
Commit rebased from bndr#210 . Credits to: pakio https://github.com/pakio
Related Issue
#51, #186, #199
Detail
Add support for jupyter notebook.
To parse notebook to python, used nbconvert library which officially provided by Project Jupyter.
note
As known issue, .ipynb which uses magic command without % cause Error when parsing script with awk.process().
For now I just left comment to let the user notice it, if you have good idea to fix it, I will be appreciated if you tell me.
Sorry for continue reopening PRs, I finally could find the reason why my coverage decreased and fixed it, also checked if the ci and coverall works fine in my repo.