dev: ensure consistency in BPS bundle result #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolly23
force-pushed
the
dev-BPS
branch
2 times, most recently
from
3b6f8b4
to
68455f7
Compare
irrun
reviewed
May 20, 2024
|
Please rebase the code to develop branch. |
Jolly23
force-pushed
the
dev-BPS
branch
2 times, most recently
from
323bf10
to
6b46c2c
Compare
unclezoro
approved these changes
May 20, 2024
irrun
approved these changes
May 21, 2024
This was referenced Jun 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit introduces a NonRevertible hash list within the RPC to address potential inconsistencies between the builder and validator during bundle operations. The builder sends a list of transaction hashes, which must be successfully executed, to the validator. If the validator cannot accurately execute the bundle, it refrains from packing that block. This mechanism ensures that both components maintain output consistency under the same input conditions, thereby preventing financial losses for searchers due to incorrect block inclusion.
Rationale
This happened on BloxRoute builder before. The simulation runs fine on builder but one transaction in bundle somehow couldn't pass on validator, which costs searcher $$$$$
Example
The builder sends the list of hashes from bundle txs that is no-revertible, to ensure the validator runs the MEV bundles right.
Changes
Notable changes:
SendBidwithNonRevertible