Skip to content

Commit

Permalink
chore: Upgrade html5lib to version 1.1. (tensorflow#5490)
Browse files Browse the repository at this point in the history
As noted by tensorflow#5478 , tensorboard fails when run in a python 3.10 environment. The reporter fortunately discovered that the problems would be fixed with an upgrade of our html5lib dependency.

I tested by building a python3.10 virtualenv on my machine (this required building python 3.10 from source as we don't have it natively).

I also ran the tensorboard with some logdirs and did some basic sanity. I specifically checked that markdown rendering seemed to be working for a couple text plugin logs that I have.
  • Loading branch information
bmd3k committed Jan 19, 2022
1 parent 90651ff commit 09d77d6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion third_party/html5lib.BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ py_library(
"html5lib/_tokenizer.py",
"html5lib/_trie/__init__.py",
"html5lib/_trie/_base.py",
"html5lib/_trie/datrie.py",
"html5lib/_trie/py.py",
"html5lib/_utils.py",
"html5lib/constants.py",
Expand Down
8 changes: 4 additions & 4 deletions third_party/python.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@ def tensorboard_python_workspace():
http_archive(
name = "org_html5lib",
urls = [
"http://mirror.tensorflow.org/github.com/html5lib/html5lib-python/archive/1.0.1.tar.gz",
"https://github.com/html5lib/html5lib-python/archive/1.0.1.tar.gz",
"http://mirror.tensorflow.org/github.com/html5lib/html5lib-python/archive/1.1.tar.gz",
"https://github.com/html5lib/html5lib-python/archive/1.1.tar.gz",
],
sha256 = "fabbebd6a55d07842087f13849076eeed350aa8bb6c9ec840f6a6aba9388db06",
strip_prefix = "html5lib-python-1.0.1",
sha256 = "66e9e24a53c10c27abb6be8a3cf2cf55824c6ea1cef8570a633cb223ec46e894",
strip_prefix = "html5lib-python-1.1",
build_file = str(Label("//third_party:html5lib.BUILD")),
)

Expand Down

0 comments on commit 09d77d6

Please sign in to comment.