Optionally implement Zeroize on ArrayVec/ArrayString #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluss
reviewed
Jun 12, 2023
Cargo.toml
Outdated
| @@ -19,6 +19,11 @@ version = "1.0" | |||
| optional = true | |||
| default-features = false | |||
|
|
|||
| [dependencies.zeroize] | |||
| version = "1.0" | |||
|
looks good to me, can you add the new feature somewhere in the github actions test matrix? In an existing case is fine. |
Done :) I used that opportunity to add benches to one of the matrix entries and to enable all features on the |
elichai
force-pushed
the
zeroize
branch
2 times, most recently
from
ccc0ce9
to
af23c59
Compare
|
Sorry, I used the wrong yaml syntax, fixed and tested locally (with |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be very useful as
ArrayVecis used in cryptographic libraries so the user might want to zero out the content (See BLAKE3-team/BLAKE3#309)P.S. I'm not sure about the use of
unsafein the test examples, I can split them into unit tests if wanted.